rewrite agg extended bounds #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
reviewed
May 16, 2024
quickwit/quickwit-search/src/leaf.rs
Outdated
| } | ||
| }); | ||
| if modified_something { | ||
| if let Ok(serialized_aggregation) = serde_json::to_string(&aggregations) { |
There was a problem hiding this comment.
I think we can use expect here
PSeitz
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4926
remove extended bounds from histogram aggregations at the leaf_search_single_split level.
This should make it possible for the partial request cache to hit on dashboards using that feature, such as grafana.
cc @PSeitz
How was this PR tested?
added integration test to verify the behavior doesn't change
added unit test to verify we rewrite the bounds at both top and leaf level
manually tested a few (manually wrote) aggregation and verify cache metrics record hits when expected.